Converting Able 5 vb object code to Able 7 C# code

[jmestep]

I'm working on implementing the old Able 5 cross sell webpages, categories function. (I see pluggables posted an add-on for some of this, but I need the cross linking to work both ways and also be able to distribute the code)
I've got most of it done, but I'm stumped on some code in the cbObjectLinkCollection.vb, which is the collection that is used to show the links at the bottom of the product page, for example. Can anyone translate this into C#? I've tried a couuple of places online and it hasn't worked for this section

Code: Select all

''' -----------------------------------------------------------------------------
		''' <summary>
		''' Gets or sets the Object_ID property.
		''' </summary>
		''' <value>The ID of the primary object.</value>
		''' <remarks>
		''' </remarks>
		''' <history>
		''' 	[loganr]	1/5/2004	Created
		''' </history>
		''' -----------------------------------------------------------------------------
		Public Property Object_ID() As Integer
			Get
				Object_ID = m_Object_ID
			End Get
			Set(ByVal Value As Integer)
				Dim i As Integer
				If m_Object_ID <> Value Then
					m_Object_ID = Value
					For i = 0 To Count - 1
						Item(i).Object_ID1 = Value
					Next
				End If
			End Set
		End Property

Here is what the translator does and it won't build because of the Item and the Count

Code: Select all

 public int ObjectType
            {
                get { ObjectType = _ObjectType; }
                set
                {
                    int i;
                    if (_ObjectType != value)
                    {
                        _ObjectType = value;
                        for (i = 0; i <= count - 1; i++)
                        {
                            item(i).ObjectType1 = value;
                        }
                    }
                }
            }

Thanks

[sohaib]

The converted code seems correct ... except may be you need to change item(i) to this if you are doing this in a collection class

Code: Select all

public int ObjectType
            {
                get { ObjectType = _ObjectType; }
                set
                {                    
                    if (_ObjectType != value)
                    {
                        _ObjectType = value;
                        for (int i = 0; i <= this.Count - 1; i++)
                        {
                            this[i].ObjectType1 = value;
                        }
                    }
                }
            }

[jmestep]

I've changed it and added an inheritance to a persistable collection to the class, so that took care of the this.Count problem. On the following code, I'm getting an error
'W2MCustomClasses.RelatedObjectLinks.W2MRelatedObjectLinkCollection.ObjectType.get': not all code paths return a value
I've tried putting return i; in at various places and I can't seem to get it right.

Code: Select all

 public Int32 ObjectType
            {
                get { ObjectType = _ObjectType; }
                set
                {
                    if (_ObjectType != value)
                    {
                        _ObjectType = value;
                        for (int i = 0; i < this.Count; i++)
                        {
                             this[i].ObjectType1 = value;
                         
                        }                      
                    }
                   
                }
            }

Thanks for your help.

[mazhar]

The get part must have a return statement. The correct code should be

Code: Select all

public Int32 ObjectType
            {
                get { return _ObjectType; }
                set
                {
                    if (_ObjectType != value)
                    {
                        _ObjectType = value;
                        for (int i = 0; i < this.Count; i++)
                        {
                             this[i].ObjectType1 = value;
                         
                        }                     
                    }
                   
                }
            }

[jmestep]

I'm back to converting this code now after creating and using other custom classes. I've made the corrections above and it's working OK.
I've translated this:

Code: Select all

Public Overloads Function IndexOf(ByVal intObjectID As Integer, ByVal intObjectType As Integer) As Integer
			Dim i As Integer = 0
			Dim intIndexOf As Integer = -1
			Dim objObjectLink As cbObjectLink
			While intIndexOf < 0 And i < Count
				objObjectLink = Item(i)
				If objObjectLink.ObjectType2 = intObjectType AndAlso objObjectLink.Object_ID2 = intObjectID Then
					intIndexOf = i
				Else
					i = i + 1
				End If
			End While
			objObjectLink = Nothing
			IndexOf = intIndexOf
		End Function

int this:

Code: Select all

 public  int IndexOf(Int32 objectId, Int32 objectType)

            {

                for (int i = 0; i < this.Count; i++)
                {
                    if ((this[i].ObjectType2 == objectType && this[i].ObjectId2 == objectId)) return i;
                }
               return -1;
                
            }

and it is OK.
The next section needs to get the object at a specific index and the VB to C# translator didn't do well on it. What is the equivalent in C# of:

Code: Select all

Public Function Item(ByVal intIndex As Integer) As cbObjectLink
			Return CType(InnerList.Item(intIndex), cbObjectLink)
		End Function

The translator does:

Code: Select all

public W2MRelatedObjectLink Item(int index)
           {

               return (W2MRelatedObjectLink)InnerList.Item(index);
            }

Thanks

[nickc]

The translators I've used invariably have problems distinguishing between method arguments and array elements - In VB, they're the same symbols "()" in C#, array is "[]" but "()" is still valid.
That's likely your issue, i.e. return (W2MRelatedObjectLink)InnerList.Item[index];

I'd also recommend "Object as Type" over (Type)Object for casting, unless there is some implicit conversion required - "as" has a great benefit in returning null instead of throwing an exception.

[jmestep]

Thanks. I'm beginning to think that at this point I need to quit trying to translate and go with new code. I've done DALs for 8 other custom objects and I understand more how the whole thing works. Now I'm back to being confused with translating from VB.