Code: Select all
Convert.ToInt32Code: Select all
AlwaysConvert.ToIntI assume that we need to live with the 'subscription' errors in the error log for now, then?There is a bug in the email signup- the default email message and the signup with verification have bad links. The email signup with notification has a bad link, but it is the unsubscribe link. I reported a bug last week after I ran into it and it is supposed to be fixed in R7.
To get rid of them for now, I've had to change the email template to not include the links, not use signup with confirmation, and replace the unsubscribe link with some generic wording about changing their subscription preferences in their account. This won't help if they are not a user on the site, but it did allow people to subscribe and stop the errors. I haven't had time to see if there is something I can do in code.Live with the subscription errors
Code: Select all
if (action == "remove")
{
//delete user from the list
int emailListId = AlwaysConvert.ToInt(Request.QueryString["list"]);
string email = Request.QueryString["email"];
string key = Request.QueryString["key"];
AbleContext.Current.Database.BeginTransaction();
..............................................
..............................................
..............................................
AbleContext.Current.Database.CommitTransaction();
}
else if (action == "confirm")
{
//ADD USER TO LIST
int emailListId = AlwaysConvert.ToInt(Request.QueryString["list"]);
string email = Request.QueryString["email"];
string key = Request.QueryString["key"];
AbleContext.Current.Database.BeginTransaction();
..............................................
..............................................
..............................................
AbleContext.Current.Database.CommitTransaction();
}
Code: Select all
//DETERMINE THE ACTION
action = action.ToLowerInvariant();
if (action == "remove")
{
//delete user from the list
int emailListId = AlwaysConvert.ToInt(Request.QueryString["list"]);
string email = Request.QueryString["email"];
string key = Request.QueryString["key"];
AbleContext.Current.Database.BeginTransaction();
EmailList list = EmailListDataSource.Load(emailListId);
if ((list != null) && (email != null))
{
string eluKey = string.Empty;
EmailListUser elu = EmailListUserDataSource.Load(emailListId, email);
if (elu != null) eluKey = elu.SignupDate.ToString("MMddyyhhmmss");
if (key == eluKey)
{
list.RemoveMember(email);
phMessage.Controls.Add(new LiteralControl(string.Format(this.DeletedMessage, list.Name)));
}
}
AbleContext.Current.Database.CommitTransaction();
}
else if (action == "confirm")
{
//ADD USER TO LIST
int emailListId = AlwaysConvert.ToInt(Request.QueryString["list"]);
string email = Request.QueryString["email"];
string key = Request.QueryString["key"];
AbleContext.Current.Database.BeginTransaction();
EmailList list = EmailListDataSource.Load(emailListId);
if ((list == null) || !ValidationHelper.IsValidEmail(email)) Response.Redirect(AbleCommerce.Code.NavigationHelper.GetHomeUrl());
EmailListSignup signup = EmailListSignupDataSource.Load(emailListId, email);
if (signup != null)
{
if (key == signup.SignupKey)
{
signup.Activate();
signup.Save();
//confirm user subscription
phMessage.Controls.Add(new LiteralControl(string.Format(this.SubscribedMessage, list.Name)));
}
AbleContext.Current.Database.CommitTransaction();
}
else if (EmailListUserDataSource.Load(emailListId, email) != null)
{
//CHECK IF USER HAS ALREADY ACTIVATED
//confirm user subscription
phMessage.Controls.Add(new LiteralControl(string.Format(this.SubscribedMessage, list.Name)));
}
}
Code: Select all
using System;
using System.Data;
using System.Configuration;
using System.Collections;
using System.Web;
using System.Web.Security;
using System.Web.UI;
using System.Web.UI.WebControls;
using System.Web.UI.WebControls.WebParts;
using System.Web.UI.HtmlControls;
using CommerceBuilder.Marketing;
using CommerceBuilder.Utility;
using CommerceBuilder.Common;
namespace AbleCommerce
{
public partial class _Subscription : CommerceBuilder.UI.AbleCommercePage
{
private string _SubscribedMessage = "Your subscription to the list {0} has been activated.";
public string SubscribedMessage
{
get { return _SubscribedMessage; }
set { _SubscribedMessage = value; }
}
private string _DeletedMessage = "Your address has been removed from the list {0}.";
public string DeletedMessage
{
get { return _DeletedMessage; }
set { _DeletedMessage = value; }
}
private string _InvalidMessage = "The subscription request was not understood or the provided parameters are incorrect.";
public string InvalidMessage
{
get { return _InvalidMessage; }
set { _InvalidMessage = value; }
}
protected void Page_Load(object sender, EventArgs e)
{
string action = Request.QueryString["action"];
if (!string.IsNullOrEmpty(action))
{
//DETERMINE THE ACTION
action = action.ToLowerInvariant();
if (action == "remove")
{
//delete user from the list
int emailListId = AlwaysConvert.ToInt(Request.QueryString["list"]);
string email = Request.QueryString["email"];
string key = Request.QueryString["key"];
AbleContext.Current.Database.BeginTransaction();
EmailList list = EmailListDataSource.Load(emailListId);
if ((list != null) && (email != null))
{
string eluKey = string.Empty;
EmailListUser elu = EmailListUserDataSource.Load(emailListId, email);
if (elu != null) eluKey = elu.SignupDate.ToString("MMddyyhhmmss");
if (key == eluKey)
{
list.RemoveMember(email);
phMessage.Controls.Add(new LiteralControl(string.Format(this.DeletedMessage, list.Name)));
}
}
AbleContext.Current.Database.CommitTransaction();
}
else if (action == "confirm")
{
//ADD USER TO LIST
int emailListId = AlwaysConvert.ToInt(Request.QueryString["list"]);
string email = Request.QueryString["email"];
string key = Request.QueryString["key"];
AbleContext.Current.Database.BeginTransaction();
EmailList list = EmailListDataSource.Load(emailListId);
if ((list == null) || !ValidationHelper.IsValidEmail(email)) Response.Redirect(AbleCommerce.Code.NavigationHelper.GetHomeUrl());
EmailListSignup signup = EmailListSignupDataSource.Load(emailListId, email);
if (signup != null)
{
if (key == signup.SignupKey)
{
signup.Activate();
signup.Save();
//confirm user subscription
phMessage.Controls.Add(new LiteralControl(string.Format(this.SubscribedMessage, list.Name)));
}
}
else if (EmailListUserDataSource.Load(emailListId, email) != null)
{
//CHECK IF USER HAS ALREADY ACTIVATED
//confirm user subscription
phMessage.Controls.Add(new LiteralControl(string.Format(this.SubscribedMessage, list.Name)));
}
}
AbleContext.Current.Database.CommitTransaction();
}
//IF RESPONSE IS EMPTY, REQUEST IS INVALID
if (phMessage.Controls.Count == 0)
phMessage.Controls.Add(new LiteralControl(this.InvalidMessage));
}
}
}
Make sure /Feeds folder is writeable by ASP.NET / Network Service user2013-11-21 08:44:25,130 ERROR AbleCommerce Error generating Google feed.
System.UnauthorizedAccessException: Access to the path 'E:\Websites\ACGold R6 Sites\Brewhaus\Feeds\GoogleFeedData.txt' is denied.
at System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)
at System.IO.FileStream.Init(String path, FileMode mode, FileAccess access, Int32 rights, Boolean useRights, FileShare share, Int32 bufferSize, FileOptions options, SECURITY_ATTRIBUTES secAttrs, String msgPath, Boolean bFromProxy, Boolean useLongPath)
at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options)
at System.IO.StreamWriter.CreateFile(String path, Boolean append)
at System.IO.StreamWriter..ctor(String path, Boolean append, Encoding encoding, Int32 bufferSize)
at System.IO.StreamWriter..ctor(String path, Boolean append)
at System.IO.File.CreateText(String path)
This error comes from system code when it tries to get the image from the requested path. I can provide you some fix that will avoid this but the error actually is an indication of something wrong somewhere else. The image URLs that are generated have invalid characters in them. These URLs are generated based on the paths stored for the images. It appears that your image paths strored in database are not valid. Please check and validate the image data, especially if you have upgraded the database or you have used some manual way of adding image paths. Like some bulk update/import operation.ERROR AbleCommerce An error has occured at http://www.brewhaus.com/GetImage.ashx?P ... s/Filter-x';",)`-lg.jpg&maintainAspectRatio=true&maxHeight=300&maxWidth=300
System.ArgumentException: Illegal characters in path.
This is a request timeout error. Most likely because of the SMTP/email server involved.2013-12-03 11:44:31,005 ERROR AbleCommerce An error has occured at http://www.brewhaus.com/Subscription.as ... 0313082321
System.Web.HttpException (0x80004005): Request timed out.
This seems to be an attempt to add a user to the email list twice. We will look into this.ERROR AbleCommerce An error has occured at http://www.brewhaus.com/Subscription.as ... 2713032753
System.Web.HttpUnhandledException (0x80004005): Exception of type 'System.Web.HttpUnhandledException' was thrown. ---> System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> NHibernate.NonUniqueObjectException: a different object with the same identifier value was already associated with the session: CommerceBuilder.Marketing.EmailListUserKey, of entity: CommerceBuilder.Marketing.EmailListUser