Recalculate Taxes error after adding item

[arawis]

Hi,
i'm using build 5410 and had a situation with an order which has been paid but is unshipped, i needed to apply a discount/refund so i used the items tab on the order then <add other item> and selected discount entered '-25' and chose 'unshippable'
then save.
the discount is recorded in the items ok , recalculate shipping button works ok but recalculate taxes button will remove the tax completely from the order(sets to 0.00) and the following error is recorded in log.

Could not recalculate with the configured tax provider: CommerceBuilder.Services.Taxes.AbleCommerce.AbleCommerceTax, CommerceBuilder
Exception: Object reference not set to an instance of an object. Stack Trace: at CommerceBuilder.Services.Taxes.AbleCommerce.LineItemCalculator.Calculate(TaxRule taxRule, Order order, Int32 shipmentId, Boolean priceIncludesTax) at CommerceBuilder.Services.Taxes.AbleCommerce.AbleCommerceTax.a(Order A_0, TaxAddress A_1, TaxRule A_2, User A_3, Boolean A_4) at CommerceBuilder.Services.Taxes.AbleCommerce.AbleCommerceTax.Recalculate(Order order) at CommerceBuilder.Taxes.TaxCalculator.Recalculate(Order order)

i've noticed that <add a product> button and recalculating taxes works fine but only if it's done before using the <add other item> button, after adding the discount the tax on the order is screwed up!
i'm assuming this is a bug but i may be trying to adjust an order in the wrong way!

any suggestions appreciated.
tia

[Katie]

Hi Tia,

I have been trying to reproduce this issue on the latest build 5731, and having no luck. Tried with a paid and unpaid order, and also tried with a discount in the same shipment and another as non-shippable. The recalculate tax button is not generating an error for me.

Can you tell me how your tax rule is configured? I want to make sure everything is setup as close as possible to your situation.

I did check the change logs from build 5410 to 5731, and there is no mention of any tax changes.

Thanks,
Katie

[arawis]

hi katie,
i've attached the tax rule

thanks for looking.

[Katie]

Hello Tia,

Ok, I think I can reproduce this now. It seems to happen when the Per Unit Calculation option is checked and the Discount is added to the order as a non-shippable item. If you add the discount to the existing shipment, it does appear to work.

I will open a bug report.

Thanks for letting us know.
Katie

[Katie]

Tia,

I had to confirm with the development team first, but when you add a discount to the order, we really don't have an easy way to calculate a new tax. Let's say there are taxable and non-taxable items in the shipment and you apply a discount after the order is placed. It wouldn't be possible to know the new taxable amount, because we couldn't possibly know how to apply the discount on the existing items in the order. I tested this in a prior version of AbleCommerce, and found the same behavior as in Gold.

The work-around suggested is to change the taxable item's price, and then use the recalculate tax feature.

The bug reported here is still valid, because you shouldn't be getting an error in any case.

Thanks,
Katie

[arawis]

ok Katie,that workaround should be fine, the only problem with adjusting the price of an item is that the customer cannot see the discount applied as a line item on the generated invoice
(and they do like to see their discounts )
thanks for your help.