paypal wrong order# showing

For general questions and discussions specific to the AbleCommerce 7.0 Asp.Net product.
Post Reply
User avatar
compunerdy
Admiral (ADM)
Admiral (ADM)
Posts: 1283
Joined: Sun Nov 18, 2007 3:55 pm

paypal wrong order# showing

Post by compunerdy » Thu Apr 16, 2009 6:34 pm

On paypals site it is showing the order ID as the order number instead of the order number. Where can this be fixed at?

User avatar
mazhar
Master Yoda
Master Yoda
Posts: 5084
Joined: Wed Jul 09, 2008 8:21 am
Contact:

Re: paypal wrong order# showing

Post by mazhar » Fri Apr 17, 2009 6:21 am

This issue is logged with BUG#7819
http://bugs.ablecommerce.com/show_bug.cgi?id=7819

Brewhaus
Vice Admiral (VADM)
Vice Admiral (VADM)
Posts: 878
Joined: Sat Jan 19, 2008 4:30 pm

Re: paypal wrong order# showing

Post by Brewhaus » Sun May 03, 2009 11:34 am

Has there been an updated file made available yet? I am a bit hesitant to mess with such an important file.
Rick Morris
Brewhaus (America) Inc.
Hot Sauce Depot

User avatar
mazhar
Master Yoda
Master Yoda
Posts: 5084
Joined: Wed Jul 09, 2008 8:21 am
Contact:

Re: paypal wrong order# showing

Post by mazhar » Mon May 04, 2009 2:57 am

Not yet, changes were made in back end. Hopefully this fix will be available in next release.

Brewhaus
Vice Admiral (VADM)
Vice Admiral (VADM)
Posts: 878
Joined: Sat Jan 19, 2008 4:30 pm

Re: paypal wrong order# showing

Post by Brewhaus » Mon May 04, 2009 6:52 am

Would making the changes listed below (from the bug report) resolve the issue? Is this all that there is to fixing the problem?
It looks like the PayNow Button is wrong, line 85 of the PayNowButton.cs code:

sb.Append("<input type=\"hidden\" name=\"item_name\" value=\"Order
No: " + button.Order.OrderId.ToString() + "\">");

Line 589 of PayPalProvider.cs:

oPaymentDetails.OrderDescription = "Order No: " +
order.OrderId.ToString();

Line 1333 of PayPalProvider.cs:

paymentDetails.OrderDescription = "Order #" + orderId.ToString();


I think all three of these locations should be updated to use order number.
For sake of consistency, change "Order No:" to "Order #" for the first two
locations as well.

I did a search in the provider solution for OrderId. It appears PayPal is the
only payment provider using OrderId incorrectly.
Rick Morris
Brewhaus (America) Inc.
Hot Sauce Depot

Post Reply